jnturton commented on code in PR #2633:
URL: https://github.com/apache/drill/pull/2633#discussion_r957433471
##########
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/values/ScalarListener.java:
##########
@@ -76,4 +79,33 @@ protected void setArrayNull() {
protected UserException typeConversionError(String jsonType) {
return loader.typeConversionError(schema(), jsonType);
}
+
+ /**
+ * Adds a field's most recent value to the pagination map. This is
necessary for the HTTP plugin
+ * for index or keyset pagination where the API transmits values in the
results that are used to
+ * generate the next page.
+ *
+ * This data is only stored if the pagination map is defined, and has keys.
Review Comment:
Can this be rewritten in terms of generic column listeners rather than
pagination and the HTTP plugin?
##########
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/parser/SimpleMessageParser.java:
##########
@@ -66,11 +68,13 @@
public class SimpleMessageParser implements MessageParser {
private final String[] path;
+ private final Map<String, Object> paginationFields;
- public SimpleMessageParser(String dataPath) {
+ public SimpleMessageParser(String dataPath, Map<String, Object>
paginationFields) {
Review Comment:
Can we rename "pagination" here too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
