cgivre commented on code in PR #2703: URL: https://github.com/apache/drill/pull/2703#discussion_r1017891449
########## exec/java-exec/src/test/resources/jsoninput/is_empty_tests.json: ########## @@ -0,0 +1,27 @@ +[ + { + "numeric_col": 1.3, + "text_col": "text", + "list_col": [ + "v1", "v2" + ], + "map_column": { + "field1": "value1", + "field2": "value2", + "nested_map": { + "nested_field1": "nested_value1", + "nested_field2" : "nested_value2" + } + } + },{ + "numeric_col": 2.3, + "text_col": "", + "list_col": [], + "map_column": {} + },{ + "numeric_col": null, + "text_col": null, + "list_col": [], + "map_column": {} + } Review Comment: @jnturton Done! I addressed your review comments. Thanks for the quick review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org