jnturton commented on code in PR #2714:
URL: https://github.com/apache/drill/pull/2714#discussion_r1044992012
##########
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSystemSchemaFactory.java:
##########
@@ -82,13 +83,21 @@ public class FileSystemSchema extends AbstractSchema {
public FileSystemSchema(String name, SchemaConfig schemaConfig) throws
IOException {
super(Collections.emptyList(), name);
final DrillFileSystem fs =
ImpersonationUtil.createFileSystem(schemaConfig.getUserName(),
plugin.getFsConf());
+ // Set OAuth Information
+ OAuthConfig oAuthConfig = plugin.getConfig().oAuthConfig();
+ if (oAuthConfig != null) {
+ OAuthEnabledFileSystem underlyingFileSystem = (OAuthEnabledFileSystem)
fs.getUnderlyingFs();
Review Comment:
Last question from me - would it work out cleaner to make
OAuthEnabledFileSystem inherit from DrillFileSystem? In particular, could that
elimnate this new getUnderlyingFs method()? Or it would cause trouble elsewhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
