jnturton commented on PR #2726: URL: https://github.com/apache/drill/pull/2726#issuecomment-1364471208
Thanks @kingswanwho, this looks good with the only issue I see being [the protobuf upgrade](https://github.com/apache/drill/pull/2726/commits/439958bc56eb2d24b7206e83a75e491ff23c89a6). In addition to the the dependency version number change, a lot of generated protobuf code needs an update. In the master branch I can see that @vvysotskyi had to add this to Dependabot's PR manually. Did you try cherry picking [his commit](https://github.com/apache/drill/pull/2671/commits/a97c7e16f01c36e5d683b561517fe8bad59cfce8) which includes the updates to generated code? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
