handmadecode commented on PR #2838: URL: https://github.com/apache/drill/pull/2838#issuecomment-1781047548
> Argh, a basic buffer arithmetic bug by _yours truly_. I guess it's remained undetected so far because Parquet v2 is still uncommon the wild. And because of insufficient Parquet v2 test coverage. I guess we've all caused our fair share of those bugs ;-) > Thank you very much for this fix which looks great. Would you mind seeing if you can relocate the test and its data? We've got TestParquetComplex already and also some Parquet v2 test files for which a naming pattern has been started, e.g. > > ``` > exec/java-exec/src/test/resources/parquet/parquet_v2_logical_types_simple.parquet Sure, how about renaming the test file to `exec/java-exec/src/test/resources/parquet/parquet_v2_large_repetition_levels.parquet`? Would you prefer if the test was moved to an existing test class, e.g. `TestParquetComplex`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
