cgivre commented on code in PR #2836: URL: https://github.com/apache/drill/pull/2836#discussion_r1375364126
########## contrib/format-daffodil/src/main/java/org/apache/drill/exec/store/daffodil/DaffodilBatchReader.java: ########## @@ -64,64 +69,97 @@ public DaffodilBatchReader (DaffodilReaderConfig readerConfig, EasySubScan scan, this.validationMode = formatConfig.getValidationMode(); // - // FIXME: Next, a MIRACLE occurs. + // FIXME: Where is this config file to be found? And, what is its syntax? Review Comment: The config file is the `DaffodilFormatConfig` file. Drill will handle the precedence for you, meaning that if the users defines the variables in a query, that will overwrite the variables stored in the Drill config. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org