mbeckerle commented on code in PR #2836:
URL: https://github.com/apache/drill/pull/2836#discussion_r1376993821
##########
contrib/format-daffodil/src/main/java/org/apache/drill/exec/store/daffodil/DaffodilBatchReader.java:
##########
@@ -64,64 +69,97 @@ public DaffodilBatchReader (DaffodilReaderConfig
readerConfig, EasySubScan scan,
this.validationMode = formatConfig.getValidationMode();
//
- // FIXME: Next, a MIRACLE occurs.
+ // FIXME: Where is this config file to be found? And, what is its syntax?
Review Comment:
No. That didn't help. I'm not looking for user help here.
A better question is this: where does a junit test put a config file so that
the test will read it?
I was trying to test my config file stuff, which was failing in completely
inscrutable ways.
Eventually tracked it down to drills insistence on file extensions.
My frustration is due to the fact that the entire boilerplate of this plugin
configuration stuff could be generated from exactly these lines of
specification:
```
name daffodil
schemaURI String null
dataURI String null
rootNamespace String ""
rootName String ""
validationMode Boolean false
```
That's it. The name is "daffodil" and it has these 5 parameters. Spending
time debugging just getting to where my code has its 5 parameters has been
quite frustrating.
I have, however, finally got past this and got a first junit test to work
end to end. Daffodil constructs drill metadata, Daffodil parses actual data and
Drill row is constructed.
I could use some help to figure out why I can't access things under
src/test/resources. I had to use absolute file URLs to get this to work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
