mbeckerle commented on PR #2836: URL: https://github.com/apache/drill/pull/2836#issuecomment-1877915796
This is ready for a next review. All the scalar types are now implemented with typed setter calls. The prior review comments have all been addressed I believe. Remaining things to do include: 1. How to get the compiled DFDL schema object so it can be loaded by daffodil out at the distributed Drill nodes. 2. Test of nilled values (and more tests generally to show deeply nested and repeating nested objects work.) 3. Errors - revisit every place errors are detected or thrown to make sure these are being done the right way for DFDL schema compilation and runtime errors as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
