shfshihuafeng commented on code in PR #2878:
URL: https://github.com/apache/drill/pull/2878#discussion_r1513766703
##########
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/MergeJoinBatch.java:
##########
@@ -297,7 +297,14 @@ public void close() {
batchMemoryManager.getAvgOutputRowWidth(),
batchMemoryManager.getTotalOutputRecords());
super.close();
- leftIterator.close();
+ try {
+ leftIterator.close();
+ } catch (Exception e) {
Review Comment:
add exception info ?
```
try {
leftIterator.close();
} catch (QueryCancelledException qce) {
throw UserException.executionError(qce)
.message("Failed when depleting incoming batches, probably because
query was cancelled " +
"by executor had some error")
.build(logger);
} catch (Exception e) {
throw UserException.internalError(e)
.message("Failed when depleting incoming batches")
.build(logger);
} finally {
// todo catch exception info or By default,the exception is thrown
directly ?
rightIterator.close();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
