cgivre commented on code in PR #2909:
URL: https://github.com/apache/drill/pull/2909#discussion_r1582202511
##########
exec/vector/src/main/java/org/apache/drill/exec/record/metadata/MapBuilder.java:
##########
@@ -185,6 +192,26 @@ public MapBuilder resumeMap() {
return (MapBuilder) parent;
}
+ /**
+ * Depending on whether the parent is a schema builder or map builder
+ * we resume appropriately.
+ */
+ @Override
+ public void resume() {
+ if (Objects.isNull(parent))
Review Comment:
@mbeckerle I don't know why the checkstyle is telling you the wrong file,
but here, you'll need braces as well as at line 203.
ie:
```java
if (parent instanceof MapBuilder) {
resumeMap();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
