cgivre commented on PR #2921:
URL: https://github.com/apache/drill/pull/2921#issuecomment-2212305704

   > Before I approve, did you consider making these JSON parsing settings 
parameters of the function itself? It feels odd to me that `store.json.*` 
settings could influence UDFs too. I'm not sure why they aren't storage plugin 
config, rather than global config, in the first place...
   
   @jnturton I thought about doing exactly what you're describing.  Here's the 
thing.  We started some work a while ago to get rid of all the non-EVF2 readers 
in Drill.  It turns out that there are a few places which still use the old 
non-EVF JSON reader.  Specifically, this UDF, the Druid Storage Plugin and the 
MongoDB storage plugin.   I started work on 
[Drill-8316](https://github.com/apache/drill/pull/2657) which addresses the 
Druid plugin and [Drill-8329](https://github.com/apache/drill/pull/2567) 
addresses converting the UDF.  Neither one of these were a high priority so 
they're kind of sitting at the moment. 
   
   I agree with your premise that the whole idea of having global settings for 
file formats (including parquet) is not the best idea.
   
    


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to