paul-rogers commented on PR #2937: URL: https://github.com/apache/drill/pull/2937#issuecomment-2332922284
This PR fixes not just the type issues above, but also the name issue and the untyped null issue. Let's not forget those. As explained earlier, you are right that backticks should never appear at runtime. Backticks are a SQL only feature. From the comment you mentioned, it could be that the `col.toExpr()` code was an ill-fated attempt to fix a real problem. Parquet (and Drill) support maps. We can thus have a map `m` with a column `foo`. The SQL name: `m.foo` or `'m'.'foo'` refer to `foo` within `m`. (Pardon the forward ticks: Markdown doesn't like nested backticks.) The bug is that the column name `m.foo` is a perfectly valid Parquet column name. So, `'m.foo'` (the entire name quoted) refers to a top level column with the `m.foo` name. We can change the code to fix the bug you discovered. We should, however, make sure we have a test for the name-with-dot/column-within-map case. We can perhaps look for unit tests associated with DRILL-4264 to understand what the original fix was trying to do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
