[I] Build fails because redundant “git.properties” definition from "pom.xml" (drill)

[via GitHub]

GangLiCN opened a new issue, #2966:
URL: https://github.com/apache/drill/issues/2966

   Before submitting a bug report, please verify that you are using the most 
current version of Drill.  
   
   **Describe the bug**
   There are some redundant “git.properties” definition from "pom.xml" which 
causes build fail.
   
   **To Reproduce**
   1. Build the project via:
   mvn clean package -DskipTests
   
   2. Build fails with below error message:
   java.nio.file.NoSuchFileException:  xxx\\distribution\..\git.properties
   
   
   **Expected behavior**
   Build should succeeds.
   
   
   **Drill version**
   1.21.2
   
   **Additional context**
   I've checked "pom.xml" and found the root cause of this issue:
   
   <configuration>
                 
<outputDirectory>${project.build.outputDirectory}</outputDirectory>
                 <resources>
                   <resource>
                     <!--suppress UnresolvedMavenProperty -->
                     <directory>${maven.multiModuleProjectDirectory}</directory>
                   </resource>
                       <include>git.properties</include>
                 </resources>
               </configuration>
   
   But,  this file also exists in  <exclude> definition, which causes conflict. 
 
   <configuration>
             <excludes>
               <!-- Please keep this list sorted. -->
               <exclude>**/*.accdb</exclude>
               <exclude>**/*.access_log</exclude>
               <exclude>**/*.access_log</exclude>
               <exclude>**/.asf.yaml</exclude>
               <exclude>**/*.autotools</exclude>
               <exclude>**/*.avi</exclude>
               <exclude>**/*.avro</exclude>
               <exclude>**/.buildpath</exclude>
               <exclude>**/*.checkstyle</exclude>
               <exclude>**/.classpath</exclude>
               <exclude>**/client/*build*/**</exclude>
               <exclude>**/clientlib/y2038/*.c</exclude> <!-- All the files 
here should have MIT License -->
               <exclude>**/clientlib/y2038/*.h</exclude> <!-- All the files 
here should have MIT License -->
               <exclude>**/client/tags</exclude>
               <exclude>**/cmake_install.cmake</exclude>
               <exclude>**/*.cnf</exclude>
               <exclude>**/control</exclude>
               <exclude>**/*.cproject</exclude>
               <exclude>**/*.css</exclude>
               <exclude>**/*.csv</exclude>
               <exclude>**/*.csvh</exclude>
               <exclude>**/*.csvh-test</exclude>
               <exclude>**/*.dbf</exclude>
               <!-- TODO DRILL-4336: try to avoid the need to add this -->
               <exclude>dependency-reduced-pom.xml</exclude>
               <exclude>**/*.drill</exclude>
               <exclude>**/.drill.parquet_metadata</exclude>
               <exclude>**/*.eps</exclude>
               <exclude>**/git.properties</exclude>
               ...
   
   
   So,  it's necessary to remove the redundant “git.properties” definition from 
<include>...</include> block.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org