cgivre commented on PR #3038: URL: https://github.com/apache/drill/pull/3038#issuecomment-4020590227
> @cgivre I was thinking more of a test that: > > * create a Jackson ObjectMapper instance > * call writeValueAsString with a representative instance of HDF5FormatConfig > * check the JSON string returned includes the values that you want > * call readVale on the ObjectMapper instance to see if the value round trips ok (ie the HDF5FormatConfig instance you get returned from readValue matches the HDF5FormatConfig instance that you started with) > > When you start playing with Jackson annotations, that affects what the serialization and deserialization does and unfortunately, Jackson releases can change the behaviour when trying to fix bugs. I added some new unit tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
