rymarm commented on PR #3036: URL: https://github.com/apache/drill/pull/3036#issuecomment-4801154269
@cgivre Thank you for the changes! Everything looks good. The only thing I wrote about that didn't seem to be understood correctly. Why do you use the full class name: ```java org.apache.calcite.sql.SqlNode parsedNode = sqlConverter.parse(scanSql.toString()); org.apache.calcite.sql.SqlNode validatedNode = sqlConverter.validate(parsedNode); ``` instead of import: ```java import org.apache.calcite.sql.SqlNode; ``` Here: https://github.com/cgivre/drill/blob/cf26170180103a55ab4ec7ba3fc2c01a0bc6855e/exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/MaterializedViewRewriter.java#L171-L171 https://github.com/cgivre/drill/blob/cf26170180103a55ab4ec7ba3fc2c01a0bc6855e/exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/MaterializedViewRewriter.java#L207-L208 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
