cgivre commented on PR #3057: URL: https://github.com/apache/drill/pull/3057#issuecomment-5111124197
> @cgivre does look like a viable solution or is too risky to add this type of validation? Classes like StatisticsHolder could in theory wrap any T type. The PolymorphicTypeValidator that I added here cover the most obvious use cases but maybe there are some that are not tested in the Drill tests but that users could be relying on? I'm honestly not sure. The unit tests all pass which is a good sign. Have you tried building Drill and testing manually? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
