letian-jiang commented on code in PR #3086: URL: https://github.com/apache/drill/pull/3086#discussion_r4390309918
########## logical/src/main/antlr4/org/apache/drill/common/expression/parser/ExprLexer.g4: ########## @@ -94,6 +94,8 @@ Bool | 'false' ; +BoundDynamicParam : 'bound_dynamic_param'; Review Comment: Thanks for the suggestion. A semantic predicate could avoid this restriction. Since a naming conflict seems unlikely, I’d prefer to keep the simpler token-based approach for now and revisit it if a practical use case arises. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
