My feeling is that the desire to get out regression fixes like https://github.com/druid-io/druid/pull/5554 faster (the original reason for doing 0.12.1) outweighs the desire to fix more bugs (including this one). So I would still vote +1 on 0.12.1 as-is and release this fix in 0.12.2 or 0.13.0.
https://github.com/druid-io/druid/pull/5805 is another candidate for a 0.12.2, if we do one, since it is a regression in 0.12.0 that we have seen crop up a few times. However the fix isn't far enough along yet to include it, and I would like to get 0.12.1 out ASAP given the nature of the bugs it is already fixing. On Wed, May 30, 2018 at 12:27 PM, Clint Wylie <[email protected]> wrote: > -1, I think we should backport this fix first > https://github.com/druid-io/druid/pull/5815 once it gets merged, since > without it queries can silently produce incorrect results. It's not a > regression afaict, but it seems pretty major bug when the conditions that > cause it are met. Sorry for being at the tail end of the vote, just found > the issue last night. > > On Tue, May 29, 2018 at 3:45 PM, Jihoon Son <[email protected]> wrote: > > > +1 > > > > On Tue, May 29, 2018 at 3:05 PM Prashant Deva <[email protected]> > > wrote: > > > > > +1 > > > Prashant > > > > > > > > > On Tue, May 29, 2018 at 1:22 PM Gian Merlino <[email protected]> > > > wrote: > > > > > > > +1 > > > > > > > > On Tue, May 29, 2018 at 11:02 AM, Jonathan Wei <[email protected]> > > > wrote: > > > > > > > > > As discussed on the sync up call this morning, let's vote on the > > 0.12.1 > > > > > release. > > > > > > > > > > Thanks, > > > > > Jon > > > > > > > > > > ------------------------------------------------------------ > > --------- > > > > > To unsubscribe, e-mail: [email protected] > > > > > For additional commands, e-mail: [email protected] > > > > > > > > > > > > > > > > > > > >
