leventov commented on a change in pull request #5980: Various changes about
druid-services module
URL: https://github.com/apache/incubator-druid/pull/5980#discussion_r201365909
##########
File path:
extensions-contrib/orc-extensions/src/test/java/io/druid/data/input/orc/OrcIndexGeneratorJobTest.java
##########
@@ -291,8 +291,8 @@ private void verifyJob(IndexGeneratorJob job) throws
IOException
Assert.assertEquals(Integer.valueOf(9),
dataSegment.getBinaryVersion());
Assert.assertEquals(dataSourceName, dataSegment.getDataSource());
- Assert.assertTrue(dataSegment.getDimensions().size() == 1);
- String[] dimensions = dataSegment.getDimensions().toArray(new
String[dataSegment.getDimensions().size()]);
+ Assert.assertEquals(1, dataSegment.getDimensions().size());
+ String[] dimensions = dataSegment.getDimensions().toArray(new
String[0]);
Review comment:
There is a corresponding inspection in IntelliJ, could you assign it ERROR
severity (you could do it via IntelliJ interface; the change should appear in
https://github.com/apache/incubator-druid/blob/master/.idea/inspectionProfiles/Druid.xml)
so such problems are caught by CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
