asdf2014 commented on a change in pull request #5980: Various changes about
druid-services module
URL: https://github.com/apache/incubator-druid/pull/5980#discussion_r201395455
##########
File path: services/src/main/java/io/druid/cli/CliPeon.java
##########
@@ -243,7 +242,7 @@ public void configure(Binder binder)
// configuration of other parameters, but I don't think that's
actually a problem.
// Note, if that is actually not a problem, then that probably
means we have the wrong abstraction.
binder.bind(SegmentLoaderConfig.class)
- .toInstance(new
SegmentLoaderConfig().withLocations(Arrays.<StorageLocationConfig>asList()));
+ .toInstance(new
SegmentLoaderConfig().withLocations(Collections.emptyList()));
Review comment:
Okay, I will add this situation to the Intellij inspection configuration
file. In this way, each newly added developer will notice this coding
specification without having to read some sort of **HOW TO CONTRIBUTE**
documents. :+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
