leventov commented on a change in pull request #5980: Various changes about a
few coding specifications
URL: https://github.com/apache/incubator-druid/pull/5980#discussion_r202515372
##########
File path: services/src/main/java/io/druid/cli/CliCoordinator.java
##########
@@ -255,6 +255,6 @@ public LoadQueueTaskMaster getLoadQueueTaskMaster(
public static boolean isOverlord(Properties properties)
{
- return
Boolean.valueOf(properties.getProperty("druid.coordinator.asOverlord.enabled")).booleanValue();
+ return
Boolean.valueOf(properties.getProperty("druid.coordinator.asOverlord.enabled"));
Review comment:
I mean there is no need to get a boxed Boolean either,
`Boolean.parseBoolean()` is a direct equivalent which returns a primitive.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
