drcrallen commented on a change in pull request #5913: Move Caching Cluster
Client to java streams and allow parallel intermediate merges
URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r202757076
##########
File path:
java-util/src/main/java/io/druid/java/util/common/concurrent/Execs.java
##########
@@ -147,4 +151,30 @@ public void rejectedExecution(Runnable r,
ThreadPoolExecutor executor)
}
);
}
+
+ private static final LongAdder fjpWorkerThreadCount = new LongAdder();
+
+ public static ForkJoinWorkerThread makeWorkerThread(String name,
ForkJoinPool pool)
+ {
+ final FJPWorkerThread t = new FJPWorkerThread(pool);
+ t.setDaemon(true);
+ fjpWorkerThreadCount.increment();
+ t.setName(StringUtils.nonStrictFormat(name,
fjpWorkerThreadCount.longValue()));
+ return t;
+ }
+
+ static class FJPWorkerThread extends ForkJoinWorkerThread
Review comment:
oh! also i forgot
` protected ForkJoinWorkerThread(ForkJoinPool pool)` so I have to subclass
it or use one of the provided fork join pool worker types, none of which quite
fit compared to just doing work in the FJP
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
