leventov commented on issue #5980: Various changes about a few coding 
specifications
URL: https://github.com/apache/incubator-druid/pull/5980#issuecomment-405661972
 
 
   @asdf2014 
   
   1. I don't know why `CostBalancerStrategyBenchmark` and 
`WrappedRoaringBitmapTest` are written in such an obscure way, you could fix 
the code to create arrays directly: `new CostBalancerStrategy[] { new 
CostBalancerStrategy(MoreExecutors.listeningDecorator(Executors.newFixedThreadPool(1)))
 }`, etc. and retain the inspection at the ERROR level.
   
   2. It was fixed only recently: 
https://youtrack.jetbrains.com/issue/IDEA-184862, probably Youtrack didn't pick 
up the fix yet. I think you could also catch all such situations using a regex, 
something like `toArray\([\s\n]*new [a-zA-Z0-9_]+\[[^0]`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to