The attachment still didn't work, but I got the example from the Superset PR. I think I'd wish for the comment to be less big. Listing out each file seems excessive. If it could be done somewhat unobtrusively then it sounds worth a try to me.
On Wed, Apr 17, 2019 at 12:41 PM Egor Ryashin < egor.ryas...@c.metamarkets.com> wrote: > I'm attaching the screenshot once more, but if it still doesn't work > here's the link to an example: > https://github.com/apache/incubator-superset/pull/7314 > [image: image.png] > > I guess, by gating you mean whether a PR approval should be based on the > report, I have no specific criteria, some code can be harder to cover with > tests, so the strict criteria are impractical, I think. But the report > gives the overview for the contributor and the reviewer both, so a > substantial gap in unit-test coverage can be spotted earlier. > > On Wed, Apr 17, 2019 at 8:23 PM Gian Merlino <g...@apache.org> wrote: > >> I'm not seeing the attached png (it shows up as a broken image). Seeing >> code coverage sounds interesting as an FYI kind of thing. I wouldn't want >> to use it as a gating factor, but seeing it could be interesting. >> >> On Wed, Apr 17, 2019 at 9:58 AM Egor Ryashin < >> egor.ryas...@c.metamarkets.com> >> wrote: >> >> > Hi, >> > >> > I wonder if we would like to integrate our repository with *C**odecov* >> and >> > receive unit test coverage reports with each PR? >> > >> > This is how it would look like on a PR page: >> > [image: code_coverage.png] >> > >> > There are multiple features, what particularly of service for me is it >> > immediately shows how PR is covered by unit tests and how it >> contributes to >> > overall coverage without looking through the code. >> > >> > Thanks, >> > Egor >> > >> > >> >
