I have submitted a pull request: #8813 for your review. Thank you, Tony Schwartz
On Fri, Nov 1, 2019 at 1:56 PM Jad Naous <jad.na...@imply.io> wrote: > Hi Tony, thank you for doing this! It would be really helpful if you can > open a PR with the change so we can review it! > > On Fri, Nov 1, 2019 at 9:50 AM Tony Schwartz <tonyschwa...@gmail.com> > wrote: > > > Yes, I was able to build the project now with my recommended code change > > and it works fine. Can someone please look into making this change? So > > far, it's the only issue I've run into with OpenJDK. > > > > Thank you, > > > > Tony Schwartz > > > > On Fri, Nov 1, 2019 at 11:34 AM Tony Schwartz <tonyschwa...@gmail.com> > > wrote: > > > > > The app fails to hand off the segments to the "historical" coordinator > > (or > > > whatever it's called) so all my segments become immediately > unavailable. > > > On the 2 versions of the latest OpenJDK (8 and 11) on which I've tried > > > this, I get the same issue. What I believe is happening can be fixed > > with > > > a code change to: DruidCoordinator.java @line 690. the instance inner > > > class CoordinatorHistoricalManagerRunnable has a constructor that is > > > referencing DruidCoordinator.this prior to the super(...) constructor > > being > > > invoked. This causes a failure. A work-around is to pass the > > coordinator > > > instance to the constructor: > > > CoordinatorHistoricalManagerRunnable(final DruidCoordinator c, final > int > > > startingLeaderCounter) > > > and then, reference c instead of DruidCoordinator.this throughout that > > > constructor method. You can probably make this a static inner class at > > > that point, although I haven't analyzed it that far. > > > > > > The exception that shows up in the coordinator-overlord.log is: > > > 2019-10-31T16:23:02,953 ERROR > > > [LeaderSelector[/druid/coordinator/_COORDINATOR]] > > > org.apache.curator.framework.listen.ListenerContainer - Listener > > > > (org.apache.druid.curator.discovery.CuratorDruidLeaderSelector$1@1e7d3d87 > > ) > > > threw an exception > > > java.lang.ClassFormatError: Illegal field name > > > "org.apache.druid.server.coordinator.DruidCoordinator$this" in class > > > > > > org/apache/druid/server/coordinator/DruidCoordinator$CoordinatorHistoricalManagerRunnable > > > > > > > > > > > > I have tried to make this change myself and to test it, but I am unable > > to > > > build the project due to rat licensing issues. Also, when I don't run > > rat > > > via the mvn build, i get another error: gpg: signing failed: No > pinentry > > > .. > > > [ERROR] Failed to execute goal > > > org.apache.maven.plugins:maven-gpg-plugin:1.6:sign > > (sign-release-artifacts) > > > on project druid: Exit code: 2 -> [Help 1] > > > > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org > > > For additional commands, e-mail: dev-h...@druid.apache.org > > > > > > > > > > > -- > Jad Naous > Imply | VP R&D > 650-521-3425 > jad.na...@imply.io >
