razinbouzar opened a new pull request, #6:
URL: https://github.com/apache/druid-operator/pull/6
Further cleanup, fix licensing logic
---
1. Added rat job (new)
rat:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Set up Java
uses: actions/setup-java@v4
with:
distribution: temurin
java-version: '11'
- name: Run Apache RAT license audit
run: make rat
Runs Apache RAT on every push and PR to master. It runs in parallel with
the tests job — if any file is missing a license
header, the pipeline fails. Java is not pre-installed on GitHub runners,
so actions/setup-java@v4 installs Temurin JDK 11
before running make rat.
2. actions/checkout@v2 → v4 in both jobs
The original used checkout@v2 which runs on Node.js 16 (EOL). v4 uses
Node.js 20, is actively maintained, and is the current
recommended version.
---
config/rbac/role.yaml
Generated by controller-gen v0.20.1 (was v0.14.0). Two changes:
1. RBAC rules compacted — resources that share the same verb set are now
grouped together (e.g. configmaps,
persistentvolumeclaims, pods, services under one rule block instead of
four separate blocks). Functionally identical — same
permissions, just deduplicated.
2. events verbs narrowed — removed delete and update from events. The
operator only needs to create/get/list/patch/watch
events, not delete or update them. This is a correctness improvement from
the newer generator.
---
chart/crds/druid.apache.org_druids.yaml
Also regenerated by controller-gen v0.20.1:
1. Version annotation updated — v0.14.0 → v0.20.1 in the metadata
2. TODO comments removed — several TODO: Add other useful fields.
apiVersion, kind, uid? stubs that were left in by the older
generator are now gone
3. Extra blank lines removed — a few double blank lines within
description: fields cleaned up
All changes are from the controller-gen upgrade — no functional impact on
the CRD schema itself.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!-- Thanks for trying to help us make Druid Operator be the best it can be!
Please fill out as much of the following information as is possible (where
relevant, and remove it when irrelevant) to help make the intention and scope
of this PR clear in order to ease review. -->
Fixes #XXXX.
<!-- Replace XXXX with the id of the issue fixed in this PR. Remove this
section if there is no corresponding issue. Don't reference the issue in the
title of this pull-request. -->
### Description
<!-- Describe the goal of this PR and the problem you encoutered while
managing Druid clusters. Something like, "I have a Druid cluster managed with
this operator and wanted to change XX on the cluster to enable YY usecase that
I needed due to ZZ requirement.". If there is a corresponding issue (referenced
above), it's not necessary to repeat the description here, however, you may
choose to keep one summary sentence. -->
<!-- Describe the possible solutions and chosen one with the rationale. -->
<!-- Describe key changes made in the patch. -->
<hr>
This PR has:
- [ ] been tested on a real K8S cluster to ensure creation of a brand new
Druid cluster works.
- [ ] been tested for backward compatibility on a real K*S cluster by
applying the changes introduced here on an existing Druid cluster. If there are
any backward incompatible changes then they have been noted in the PR
description.
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added documentation for new or modified features or behaviors.
<hr>
##### Key changed/added files in this PR
* `MyFoo`
* `OurBar`
* `TheirBaz`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
