pjain1 commented on PR #20:
URL: https://github.com/apache/druid-operator/pull/20#issuecomment-4458986204
Codex review
```
1. Medium - apis/druid/v1alpha1/druid_types.go:276: DefaultProbes changed
to *bool, but generated artifacts are not updated. make generate adds the
missing deep-copy block for the bool pointer; without it, DruidSpec.DeepCopy()
aliases the pointer instead of copying it. make
manifests also changes config/crd/... and chart/crds/..., and make
api-docs updates the API docs.
2. Medium - apis/druid/v1alpha1/druid_types.go:273: the field comment says
DefaultProbes defaults to true, but the PR removes +kubebuilder:default:=true.
Once manifests are regenerated, the CRD no longer advertises or applies that
default. I’d keep the CRD default marker on the
*bool field and still keep the nil check in the controller for
in-memory/un-defaulted objects.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
