beiwei30 opened a new issue #1557: sometimes dubbo can choose wrong IP which hangs brave's integration test. URL: https://github.com/apache/incubator-dubbo/issues/1557 fyi I noticed sometimes dubbo can choose wrong IP. for example hangs our integration tests openzipkin/brave#680 we use this approach when guessing ```java Enumeration<NetworkInterface> nics = NetworkInterface.getNetworkInterfaces(); if (nics == null) return builder.build(); while (nics.hasMoreElements()) { NetworkInterface nic = nics.nextElement(); Enumeration<InetAddress> addresses = nic.getInetAddresses(); while (addresses.hasMoreElements()) { InetAddress address = addresses.nextElement(); if (address.isSiteLocalAddress()) { builder.ip(address); break; } } } ``` https://github.com/openzipkin/brave/blob/master/brave/src/main/java/brave/internal/Platform.java#L63 anyway not sure it breaks other people as unit tests are one thing.. production use another
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
