cvictory commented on issue #1426: fix isShutdown always return true
URL: https://github.com/apache/incubator-dubbo/pull/1426#issuecomment-379515269
 
 
   Review the commit , change isShutdown to isTerminated. 
   
   * java.util.concurrent.ExecutorService#isShutdown will return true , after 
invoking shutdown or shutdownNow.
   * java.util.concurrent.ExecutorService#isTerminated will return true, after 
all tasks have completed execution.
   
   It is correct about this modification.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to