zonghaishang commented on a change in pull request #1550: [Dubbo-Fix 
EnableDubbo annotation bug]
URL: https://github.com/apache/incubator-dubbo/pull/1550#discussion_r179935223
 
 

 ##########
 File path: 
dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/context/annotation/DubboClassPathBeanDefinitionScanner.java
 ##########
 @@ -53,7 +53,7 @@ public 
DubboClassPathBeanDefinitionScanner(BeanDefinitionRegistry registry, bool
     public DubboClassPathBeanDefinitionScanner(BeanDefinitionRegistry 
registry, Environment environment,
                                                ResourceLoader resourceLoader) {
 
-        this(registry, false, environment, resourceLoader);
+        this(registry, true, environment, resourceLoader);
 
 Review comment:
   
com.alibaba.dubbo.config.spring.beans.factory.annotation.ServiceAnnotationBeanPostProcessor#registerServiceBeans:
   
   ```
           scanner.addExcludeFilter(new AnnotationTypeFilter(Component.class, 
false));
           scanner.addExcludeFilter(new AnnotationTypeFilter(Controller.class, 
false));
           scanner.addExcludeFilter(new AnnotationTypeFilter(Repository.class, 
false));
   ```
   
   I have filtered that, @EnableDubbo should support client scanning.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to