beiwei30 commented on a change in pull request #1407: [Dubbo-1510] dubbo 
monitor missing parameters
URL: https://github.com/apache/incubator-dubbo/pull/1407#discussion_r179933412
 
 

 ##########
 File path: 
dubbo-monitor/dubbo-monitor-default/src/main/java/com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java
 ##########
 @@ -92,6 +93,7 @@ public void send() {
             long maxOutput = numbers[7];
             long maxElapsed = numbers[8];
             long maxConcurrent = numbers[9];
+            String version = getUrl().getParameter(Constants.DEFAULT_PROTOCOL);
 
 Review comment:
   why `DEFAULT_PROTOCOL` is necessary to collect?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to