HouZhiHouJue opened a new issue #1508: feature required: set registrydirectory 
to AP when implementation is CP
URL: https://github.com/apache/incubator-dubbo/issues/1508
   when register center lost all provider instance , it's doesn't mean that the 
consumers are all disconnected from the providers,so the method  
refreshInvoker(List<URL> invokerUrls) ; in registrydirectory is not so fault 
tolerance.the method code is :
   ` private void refreshInvoker(List<URL> invokerUrls) {
           if (invokerUrls != null && invokerUrls.size() == 1 && 
invokerUrls.get(0) != null
Constants.EMPTY_PROTOCOL.equals(invokerUrls.get(0).getProtocol())) {
               this.forbidden = true; // Forbid to access
               this.methodInvokerMap = null; // Set the method invoker map to 
               destroyAllInvokers(); // Close all invokers
           } else {
   here when invokerUrls  is empty ,all the invokers are destryed, but in 
fact,ignore it  will be more fault tolerance.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

Reply via email to