codecov-io commented on issue #1584: add more unit test for registry modules URL: https://github.com/apache/incubator-dubbo/pull/1584#issuecomment-380103118 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1584?src=pr&el=h1) Report > Merging [#1584](https://codecov.io/gh/apache/incubator-dubbo/pull/1584?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/d80a42cc69d16d3cb3391ba9f5ec2cc64436839f?src=pr&el=desc) will **increase** coverage by `0.66%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/1584?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #1584 +/- ## ============================================ + Coverage 34.56% 35.23% +0.66% - Complexity 3688 3739 +51 ============================================ Files 621 621 Lines 30875 30875 Branches 5448 5448 ============================================ + Hits 10673 10879 +206 + Misses 18367 18106 -261 - Partials 1835 1890 +55 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1584?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ba/dubbo/remoting/transport/netty/NettyClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1584/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDbGllbnQuamF2YQ==) | `74.13% <0%> (-8.63%)` | `12% <0%> (-1%)` | | | [...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1584/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9DaGFubmVsV3JhcHBlZEludm9rZXIuamF2YQ==) | `41.66% <0%> (-4.17%)` | `3% <0%> (ø)` | | | [...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1584/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby90ZWxuZXQvSW52b2tlVGVsbmV0SGFuZGxlci5qYXZh) | `51.89% <0%> (-3.8%)` | `11% <0%> (-2%)` | | | [.../dubbo/rpc/protocol/dubbo/filter/FutureFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1584/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9maWx0ZXIvRnV0dXJlRmlsdGVyLmphdmE=) | `54.54% <0%> (-2.03%)` | `13% <0%> (ø)` | | | [...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1584/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9DYWxsYmFja1NlcnZpY2VDb2RlYy5qYXZh) | `78.67% <0%> (-1.48%)` | `29% <0%> (-1%)` | | | [...ba/dubbo/registry/multicast/MulticastRegistry.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1584/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktbXVsdGljYXN0L3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVnaXN0cnkvbXVsdGljYXN0L011bHRpY2FzdFJlZ2lzdHJ5LmphdmE=) | `44.53% <0%> (+1.26%)` | `28% <0%> (+4%)` | :arrow_up: | | [...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1584/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0FjdGl2ZUxpbWl0RmlsdGVyLmphdmE=) | `88.88% <0%> (+5.55%)` | `7% <0%> (+1%)` | :arrow_up: | | [...om/alibaba/dubbo/registry/redis/RedisRegistry.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1584/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktcmVkaXMvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZWdpc3RyeS9yZWRpcy9SZWRpc1JlZ2lzdHJ5LmphdmE=) | `32.58% <0%> (+32.58%)` | `16% <0%> (+16%)` | :arrow_up: | | [...ba/dubbo/registry/zookeeper/ZookeeperRegistry.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1584/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktem9va2VlcGVyL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVnaXN0cnkvem9va2VlcGVyL1pvb2tlZXBlclJlZ2lzdHJ5LmphdmE=) | `67.6% <0%> (+64.08%)` | `30% <0%> (+27%)` | :arrow_up: | | [...o/registry/zookeeper/ZookeeperRegistryFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1584/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktem9va2VlcGVyL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVnaXN0cnkvem9va2VlcGVyL1pvb2tlZXBlclJlZ2lzdHJ5RmFjdG9yeS5qYXZh) | `100% <0%> (+100%)` | `3% <0%> (+3%)` | :arrow_up: | | ... and [2 more](https://codecov.io/gh/apache/incubator-dubbo/pull/1584/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1584?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1584?src=pr&el=footer). Last update [d80a42c...5c226f9](https://codecov.io/gh/apache/incubator-dubbo/pull/1584?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
