chickenlj commented on issue #1557: sometimes dubbo can choose wrong IP which 
hangs brave's integration test.
URL: 
https://github.com/apache/incubator-dubbo/issues/1557#issuecomment-380728592
 
 
   Dubbo will try to retrieve ip in the following orders:
   1.  outer configurations(e.g., system environment variables)
   2.  hosts mapping
   3.  guess by traversing the network` interface.
       * the interface that can connect to remote registry.
       * first interface has valid ip address.
   
   As for guessing approach, Dubbo almost uses the same approach as 
zipkin/brave does: 
https://github.com/openzipkin/brave/blob/master/brave/src/main/java/brave/internal/Platform.java#L63,
 **except for it does not  check `if (address.isSiteLocalAddress()) {`**. I am 
not sure if  site-local addresses: 10/8, 172.16/12 and 192.168/16 the best 
choice for dubbo.
   
   The deploy environment for dubbo varies, we highly recommend rely on the 
first two approaches, specifying the ip you want explicitly can be the best 
way, avoid guessing as it's unpredictable.  In a docker environment, bind the 
docker ip or host ip can depends, leave the choice to users.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to