zonghaishang opened a new pull request #1607: [Dubbo-shutdown gracefully]  fix 
shutdown gracefully.
URL: https://github.com/apache/incubator-dubbo/pull/1607
 
 
   ## What is the purpose of the change
   
   1. fix jvm shutdown gracefully bug, including annotation bean and server 
running state error. see: https://github.com/apache/incubator-dubbo/issues/1606
   
   ## Brief changelog
   
   1. 
`com.alibaba.dubbo.remoting.exchange.support.header.HeaderExchangeServer#close(int)`,
 solve the problem of the dubbo unable to sleep thread.
   2. `com.alibaba.dubbo.config.spring.AnnotationBean#destroy`ļ¼Œsolve the use of 
annotations can not elegantly stop the scene.
   
   ## Verifying this change
   
   1. DubboInvokerAvilableTest#test_normal_channel_close_wait_gracefully
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
   - [x] Make sure there is a 
[GITHUB_issue](https://github.com/alibaba/dubbo/issues) filed for the change 
(usually before you start working on it). Trivial changes like typos do not 
require a GITHUB issue. Your pull request should address just this issue, 
without pulling in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[Dubbo-XXX] Fix UnknownException 
when host config not exist`. Each commit in the pull request should have a 
meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [x] Write necessary unit-test to verify your logic correction, more mock a 
little better when cross module dependency exist. If the new feature or 
significant change is committed, please remember to add integration-test in 
[test module](https://github.com/alibaba/dubbo/tree/master/dubbo-test).
   - [x] Run `mvn clean install -DskipITs` to make sure unit-test pass. Run 
`mvn clean test-compile failsafe:integration-test`  to make sure 
integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual 
Contributor License Agreement](http://www.apache.org/licenses/#clas).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to