takeseem commented on a change in pull request #1232: Fix hessian2 serialized short, byte is converted to int bug URL: https://github.com/apache/incubator-dubbo/pull/1232#discussion_r181568188
########## File path: hessian-lite/src/main/java/com/alibaba/com/caucho/hessian/io/AbstractHessianInput.java ########## @@ -334,12 +335,34 @@ abstract public InputStream readInputStream() abstract public Object readObject(Class expectedClass) throws IOException; + /** + * Reads an arbitrary object from the input stream. + * + * @param expectedClass the expected class if the protocol doesn't supply it. + * @param expectedTypes the runtime type hints, eg: expectedClass equals Map, expectedTypes can + * equals String.class, Short.class + */ + public Object readObject(Class expectedClass, Class<?>... expectedTypes) Review comment: the add method will work in Hessian2Input, but in HessianInput not unsupported. I think the HessianInput need to change to support the new methods. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services