takeseem commented on issue #1608: fix #210 
JavaDeserializer._constructor.newInstance([null, null]) NPE
URL: https://github.com/apache/incubator-dubbo/pull/1608#issuecomment-381570303
 
 
   既然AbstracthessianInput增加了方法,为什么heassian2能兼容和heassian1就不支持?
   
   1. The new abstract method I added did not implement in Hessian1 by default, 
you should not reuse my hessian2 unit test to verify hessian1.
     虽然是开源项目,假设客户已经在生产中使用hessian1,这对客户来说升级版本将是灾难。
     所以我说不严谨
   2. Does it need to support hessian1, maybe I will support later today.
     点赞
   3. #210 is inconsistent with the given line number, perhaps due to the 
version used by the spring-jdbc framework
     我会根据git的show revision information找到我需要的信息,虽然#210 案例看最新代码依然能定位问题。

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to