mercyblitz commented on a change in pull request #1611: Spring Framework /
Spring Boot Enhancements
URL: https://github.com/apache/incubator-dubbo/pull/1611#discussion_r183277908
##########
File path:
dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/beans/factory/annotation/ReferenceAnnotationBeanPostProcessor.java
##########
@@ -360,11 +400,17 @@ private Object buildReferenceBean(Reference reference,
Class<?> referenceClass)
* @param beanClass {@link Class}
* @return
*/
- private static String generateReferenceBeanCacheKey(Reference reference,
Class<?> beanClass) {
+ private String generateReferenceBeanCacheKey(Reference reference, Class<?>
beanClass) {
String interfaceName = resolveInterfaceName(reference, beanClass);
- String key = reference.group() + "/" + interfaceName + ":" +
reference.version();
+ String key = reference.url() + "/" + interfaceName +
Review comment:
It's the same in JVM, switch to StringBuilder is welcome
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
