Hi, On Fri, May 11, 2018 at 12:05 PM, Justin Mclean <[email protected]> wrote: > Hi, > > I saw that a release candidate has been put up here [1] and I had a quick > look at it. It looks good to me with a couple of minor issues: > - The binary LICENSE fails to mention FastJSON (but as this is ALv2 it’s not > required) Not this will make the connivance binary LICENSE file different to > the source LICENSE file > - The binary jars in libs are missing LICENSE and NOTICE files in META-INF
Just a quick question, should the LICENSE and NOTICE file in META-INF only contain information in this specific jar, or should contain information of the entire binary? > > You may want to fix these before calling a vote but I think this sees could > be fixed in the next release if you prefer that. Other mentors/PMC member may > have a different opinion to me. If this is not something cost us too much work, I think we can fix it. > > Thanks, > Justin > > 1. https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.2/ -- Best Regards！ Huxing
