Hi, +1
I checked: - name includes incubating - signatures and hashes correct - disclaimer exists - LICENSE and NOTICE correct - No binary files in release - Can compile from source - The binary distribution (with different license and notice files) also looks good. Some minor problems could be recorded in the next release checklist. Such as, not all source files have apache headers(nat are not always work well), odd unzip file name etc. Best Regards, Von Gosling > 在 2018年5月16日，10:55，Justin Mclean <[email protected]> 写道： > > Hi, > > +1 (binding) > > I checked: > - Incubating in name > - Signatures and hashes good > - DISCLAIMER exists > - LICENSE and NOTICE good > - A number of pom.xml and log4j.xml files haven’t had their headers changed > to the standard ASF one and are still copyright Alibaba (about 14 files) e.g > [4][5] > - A couple of .sh files are missing ASF headers in [6] also here [9] and here > [10] > - No unexpected binary files in the release > - Can compile from source > > I also checked the binary convenience release and it's all good re > signatures, naming, disclaimer, licenses and notice. > > Some very minor issues (and IMO except for the MD5 issue) can be fixed next > release: > - Can you remove the MD5 hashes please they are not needed and don’t follow > the current release policy. [1] > - The source unzips into an odd directory name "dubbo-parent-2.6.2”, > “apache-dubbo-2.6.2” would be better. > - The code of conduct may need some small updates for instance I see > "[email protected]” mentioned. > - The README.md has links to information would be nice to include build > instructions inside the README > - A few poms have some out of date information [2][3] > - The contributing document need a couple of minor updates (eg @author tags > are not used at Apache) > - LICENSE includes " Copyright (c) 2001-2004 Caucho Technology, Inc” but some > of the header have the date range 2001-2008 > - Should these files be in the release? [7][8] > - Maven check style plugin is taking a long time when compiling (10+minutes) > and runs out of memory on my machine. Disabling it (-Dcheckstyle.skip) > reduced compile time to under a minute. > > I’ve not checked if the compile source actually works (which is sort of > important) so might be good if a few people check that when voting +1 :-) > > Well done! It's not often I get to vote +1 on the first RC of a first release > by a project. > > Thanks, > Justin > > 1. https://www.apache.org/dev/release-distribution.html#sigs-and-sums > 2. ./bom/pom.xml > 3. ./dependencies-bom/pom.xml > 4. ./dubbo-rpc/dubbo-rpc-rest/pom.xml > 5. ./dubbo-common/src/test/resources/log4j.xml > 6. > dubbo-container/dubbo-container-api/src/main/resources/META-INF/assembly/bin/*.sh > 7. dubbo-rpc/dubbo-rpc-default/dubbo.log > 8. dubbo-rpc/dubbo-rpc-dubbo/dubbo.log > 9. dubbo-test/dubbo-test-benchmark/src/main/resources/run.* > 10. dubbo-test/dubbo-test-benchmark/src/test/resources/server/*.sh
