good suggestion, thanks Mark. I will submit another checkin to rename this access log to more general name.
On Tue, Jul 10, 2018 at 5:05 AM Mark Thomas <[email protected]> wrote: > You should consider a further rename to remove the reference to alibaba > completely (and any similar file names). References to specific > commercial entities in the code can give the wrong impression regarding > project independence. > > Mark > > > -------- Forwarded Message -------- > Subject: [GitHub] beiwei30 closed pull request #2051: rename access log > in unit test from 'alibaba' to 'alibaba.log' > Date: Mon, 09 Jul 2018 06:44:52 -0000 > From: GitBox <[email protected]> > Reply-To: [email protected] > To: [email protected] > > beiwei30 closed pull request #2051: rename access log in unit test from > 'alibaba' to 'alibaba.log' URL: > https://github.com/apache/incubator-dubbo/pull/2051 > > This is a PR merged from a forked repository. > As GitHub hides the original diff on merge, it is displayed below for > the sake of provenance: > > As this is a foreign pull request (from a fork), the diff is supplied > below (as it won't show otherwise due to GitHub magic): > > diff --git > > a/dubbo-rpc/dubbo-rpc-api/src/test/java/org/apache/dubbo/rpc/filter/AccessLogFilterTest.java > > b/dubbo-rpc/dubbo-rpc-api/src/test/java/org/apache/dubbo/rpc/filter/AccessLogFilterTest.java > index 5db1127791..8e5c426697 100644 > --- > > a/dubbo-rpc/dubbo-rpc-api/src/test/java/org/apache/dubbo/rpc/filter/AccessLogFilterTest.java > +++ > > b/dubbo-rpc/dubbo-rpc-api/src/test/java/org/apache/dubbo/rpc/filter/AccessLogFilterTest.java > @@ -57,7 +57,7 @@ public void testDefault() { > @Test > public void testCustom() { > - URL url = URL.valueOf("test://test:11/test?accesslog=alibaba"); > + URL url = > URL.valueOf("test://test:11/test?accesslog=alibaba.log"); > Invoker<AccessLogFilterTest> invoker = new > MyInvoker<AccessLogFilterTest>(url); > Invocation invocation = new MockInvocation(); > accessLogFilter.invoke(invoker, invocation); > > > > ---------------------------------------------------------------- > This is an automated message from the Apache Git Service. > To respond to the message, please log on GitHub and use the > URL above to go to the specific comment. > For queries about this service, please contact Infrastructure at: > [email protected] > > > With regards, > Apache Git Services > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
