> I think I found an issue that may need to rebuild the release candidate.
> 
> The source release contains a binary:
> 
> ./.mvn/wrapper/maven-wrapper.jar

Yes, you are right, I have just checked and found the binary in the exact 
position.
We can start the rebuild today. 

I failed to notice that the rat and style plugin are closed by default when 
building the release candidate locally, I will open them in the next RC, they 
can help to check this kind of problems.

Best regards,
Jun

> On 29 Jul 2018, at 16:14, Huxing Zhang <[email protected]> wrote:
> 
> Hi,
> 
> I think I found an issue that may need to rebuild the release candidate.
> 
> The source release contains a binary:
> 
> ./.mvn/wrapper/maven-wrapper.jar
> 
> Actually I run `mvn verify -Drat.skip=false`, as a result it found the
> archive in target/rat.txt but did not fail.
> 
> Notes: 3
> Binaries: 0
> Archives: 1
> Standards: 3
> 
> Apache Licensed: 3
> Generated Documents: 0
> 
> JavaDocs are generated, thus a license header is optional.
> Generated files do not require license headers.
> 
> 0 Unknown Licenses
> 
> Archives:
> 
> + .mvn/wrapper/maven-wrapper.jar
> 
> Previous discussion:
> https://lists.apache.org/thread.html/491ecd01802c48df8d906548e1d1db188c39a9546f958e834198d276@%3Cdev.dubbo.apache.org%3E
> 
> 
> Other details:
> 
> * incubator in name
> * Disclaimer exists
> * sha512 chesum ok
> * signature ok
> * git tag matches
> * NOTICE and LICENSE exist in META-INF of jar files of binary release.
> * Unit test passed on Java 8 + OSX
> * Tested elegant shutdown with Tomcat 8.5.30
> 
> Minor issues:
> * There are some typo in CHANGES.md, I saw it fixed in 2.6.3 release
> branch, but not included in the release candidate.
> 
> On Thu, Jul 26, 2018 at 5:48 PM, Jun Liu <[email protected]> wrote:
>> Hello Dubbo Community,
>> 
>> This is a call for vote to release Apache Dubbo (Incubating) version 2.6.3.
>> 
>> The release candidates (RC1):
>> https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.3
>> 
>> Git tag for the release (RC1):
>> https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.3
>> 
>> Hash for the release tag:
>> a8be0eaaddab198ed03b0150d4db03e2b22f023f
>> 
>> Release Notes:
>> https://github.com/apache/incubator-dubbo/blob/2.6.3-release/CHANGES.md
>> 
>> The artifacts have been signed with Key : 28681CB1, which can be found in 
>> the keys file:
>> https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS
>> 
>> The vote will be open for at least 72 hours or until necessary number of 
>> votes are reached.
>> 
>> Please vote accordingly:
>> 
>> [ ] +1 approve
>> [ ] +0 no opinion
>> [ ] -1 disapprove with the reason
>> 
>> Thanks,
>> The Apache Dubbo (Incubating) Team
>> 
> 
> -- 
> Best Regards!
> Huxing

Reply via email to