I run `mvn clean pakcage` in Mac with java 8. All pass
On 2018/08/02 01:39:03, Huxing Zhang <[email protected]> wrote: > Hi, > > On Wed, Aug 1, 2018 at 5:44 PM, Andrea Del Bene <[email protected]> wrote: > > Hi, > > > > running 'mvn clean test' on 2.6.3 release branch and on 2.6.x tag I get a > > failure with the following unit test: > > > > ------------------------------------------------------------------------------- > > Test set: com.alibaba.dubbo.config.AbstractInterfaceConfigTest > > ------------------------------------------------------------------------------- > > Tests run: 38, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.127 sec > > <<< FAILURE! - in com.alibaba.dubbo.config.AbstractInterfaceConfigTest > > checkApplication1(com.alibaba.dubbo.config.AbstractInterfaceConfigTest) > > Time elapsed: 0.006 sec <<< FAILURE! > > junit.framework.ComparisonFailure: expected:<10[0]> but was:<10[]> > > at > > com.alibaba.dubbo.config.AbstractInterfaceConfigTest.checkApplication1(AbstractInterfaceConfigTest.java:90) > > > > I'm working on Ubuntu 16.04 64 bit, Maven 3.5.3 and Java 1.8.0_181. At the > > moment I have no clue about what might be wrong. On branch master > > (2.7.0-SNAPSHOT) everything is ok, every test passes. > > This is weird, the test passed without any error on my MACOS laptop. > Are you constantly getting this error? If so I guess the best way is > debugging. > This test basically writes the property to a file, and then read it > back in com.alibaba.dubbo.config.AbstractInterfaceConfig#checkApplication. > > If it occurs occasionally, I would suggest to add some logs in > com.alibaba.dubbo.config.AbstractInterfaceConfig#checkApplication to > see what happened to > ConfigUtils.getProperty(Constants.SHUTDOWN_WAIT_KEY); > > > > > > > On Wed, Aug 1, 2018 at 10:06 AM, Huxing Zhang <[email protected]> wrote: > > > >> +1 (binding) to release. > >> > >> I've checked: > >> > >> * incubator in name > >> * Disclaimer exists > >> * sha512 chesum ok > >> * signature ok > >> * git tag matches > >> * NOTICE and LICENSE exist in META-INF of jar files of binary release. > >> * Unit test passed on Java 8 + OSX > >> * Tested elegant shutdown with Tomcat 8.5.30 > >> > >> Minor issues: > >> * There are some typo in CHANGES.md, I saw it fixed in 2.6.3 release > >> branch, but not included in the release candidate. > >> * I think we need to add more examples to the convenient binary > >> release, so that users can quickly try Dubbo out, currently there is > >> only packaged jars. > >> > >> On Tue, Jul 31, 2018 at 11:51 AM, Jun Liu <[email protected]> wrote: > >> > Hello Dubbo Community, > >> > > >> > This is a call for vote to release Apache Dubbo (Incubating) version > >> 2.6.3. > >> > > >> > The release candidates (RC2): > >> > https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.3 > >> > > >> > Git tag for the release (RC2): > >> > https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.3 > >> > > >> > Hash for the release tag: > >> > a8be0eaaddab198ed03b0150d4db03e2b22f023f > >> > > >> > Release Notes: > >> > https://github.com/apache/incubator-dubbo/blob/2.6.3-release/CHANGES.md > >> > > >> > The artifacts have been signed with Key : 28681CB1, which can be found > >> in the keys file: > >> > https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS > >> > > >> > The vote will be open for at least 72 hours or until necessary number of > >> votes are reached. > >> > > >> > Please vote accordingly: > >> > > >> > [ ] +1 approve > >> > [ ] +0 no opinion > >> > [ ] -1 disapprove with the reason > >> > > >> > The previously RC1 vote thread: > >> > https://lists.apache.org/thread.html/6371153d4fd5645615c14518f70f42 > >> 3134b08148c2fba72e5bb63a55@%3Cdev.dubbo.apache.org%3E > >> > > >> > Thanks, > >> > The Apache Dubbo (Incubating) Team > >> > > >> > Best regards, > >> > Jun > >> > > >> > >> > >> > >> -- > >> Best Regards！ > >> Huxing > >> > > > > > > > > -- > > Andrea Del Bene. > > Apache Wicket committer. > > > > -- > Best Regards！ > Huxing >
