On Wed, Aug 22, 2018 at 7:58 PM Ian Luo <[email protected]> wrote: > see my comments inlined below. > > > On Wed, Aug 22, 2018 at 6:11 PM ulinkwo <[email protected]> wrote: > > > Hi, community > > > > I plan to contribute for the Issue ( > > https://github.com/apache/incubator-dubbo/issues/2316), But I could not > > know which version release contains the issue. > > > > Right now I the dubbo-serialization-fst based master code > (2.7.0-SNAPSHOT), > > so CI fails to build because it could not to find dubbo dependency > version. > > Why not to deploy dubbo-2.7.0-SNAPSHOT to central repo ? > > > > CI should fail when some module is removed from the master, would you mind > to provide the link? Furthermore, I think the correct sequence should be > move the module into github.com/dubbo first, then remove the corresponding > module from the main project, what do you think? > > It's not the problem about sequence, but the dependency of the moving module. It depends on the 2.7.x bom, but it's also on developing, so CI failed.
The question is whether we need to deploy 2.7.0-SNAPSHOT to central repository so that these moving modules can build successfully. > > > > > What plan for this issue to finish all migrations, Do we need to support > > 2.6.x which contains all modules ? > > > > We should leave branch 2.6.x as is, since it is delegated to maintenance > purpose. > > +1, This is a big change that is not suitable on 2.6.x > > > > Sincerely. > > > > Kyle > > >
