Sorry for my delay. Does the new maven fix it? If not, l will fix the code this night :)
发自我的 iPhone > 在 2018年9月11日，下午3:46，Ian Luo <[email protected]> 写道： > > Kun, I merged your code. > > -Ian. > >> On Tue, Sep 11, 2018 at 2:11 PM Ian Luo <[email protected]> wrote: >> >> Kun, your scala sample looks pretty good. I kicked a new build just now, >> let's see how it's going for this time. >> >>> On Tue, Sep 11, 2018 at 2:03 PM Ian Luo <[email protected]> wrote: >>> >>> Kun, >>> >>> It fails with >>> >>> [ERROR] Failed to execute goal >>>> net.alchim31.maven:scala-maven-plugin:3.3.3:compile (default) on project >>>> dubbo-samples-scala: The plugin net.alchim31.maven:scala-maven-plugin:3.3.3 >>>> requires Maven version 3.5.3 -> [Help 1] >>> >>> >>> I upgrade maven to 3.5.4, pls. merge the latest change and try it again. >>> >>> -Ian. >>> >>> >>>> On Tue, Sep 11, 2018 at 10:15 AM YunKun Huang <[email protected]> wrote: >>>> >>>> It's good to have a scala sample, but I notice the CI fail in your PR. >>>> >>>> ``` >>>> Failed to execute goal >>>> net.alchim31.maven:scala-maven-plugin:3.3.3:compile (default) on project >>>> dubbo-samples-scala: The plugin net.alchim31.maven:scala-maven-plugin:3.3.3 >>>> requires Maven version 3.5.3 >>>> ``` >>>> >>>>> On 2018/09/11 00:22:34, Kun Song <[email protected]> wrote: >>>>> Hi community, I add a Dubbo sample with Scala(not merge yet), aiming >>>> to equip our user with the power of Scala >>>>> >>>>> And if you’re interested in it, you can review the PR here >>>> https://github.com/dubbo/dubbo-samples/pull/28 < >>>> https://github.com/dubbo/dubbo-samples/pull/28>. >>>>> >>>>> Happy for any feedback :) >>>> >>>
