On Mon, Sep 10, 2018 at 10:10 AM yuhang xiu <[email protected]> wrote: > > Hi Huxing, > This is because there is a bug that causes them to be inconsistent. We > removed the async attribute from the Provider in ClusterUtil, but did not > remove the method.async attribute, causing the Provider's method.async to > affect the Consumer side. > > We don't need extra configuration, we just need to remove method.async in > ClusterUtil to solve this problem, and we don't need to modify the URL of > the Provider registered in the registry.
Thanks for the explanation, it looks good to me! > > Huxing Zhang <[email protected]> 于2018年9月7日周五 下午11:40写道： > > > Hi, > > > > On Wed, Sep 5, 2018 at 3:30 PM yuhang xiu <[email protected]> wrote: > > > > > > Hi community, > > > > > > Recently I found a bug[1] in the issue list (submitted by the > > > https://github.com/fingthinking user), which has been verified to be > > valid. > > > The root cause of the problem is that the Provider registered the > > > method.async to the registry and finally affected the Consumer side. > > > > > > The user submitted pr[2] to fix the problem. The fix is that the provider > > > does not register the method.async to the registry, so the Consumer side > > > cannot perceive it. > > > I think this way is not the best. I think the best way is that the > > Provider > > > side still registers method.async to the registry, but the Consumer side > > > ignores this property. > > > > Do you have any idea how to achieve this? Do we need to have extra > > configuration on consumer side? > > Or is it a special case? > > > > > The advantage is that in the future we can still see > > > the asynchronous situation of the various methods of the provider on > > > dubbo-ops, > > > > +1 > > > > > and this processing method is more in line with the purpose of > > > dubbo configuration coverage. > > > > > > What do you think about it? > > > > > > [1]https://github.com/apache/incubator-dubbo/issues/2321 > > > [2]https://github.com/apache/incubator-dubbo/pull/2322 > > > > I also noticed that you have replied on the issue: > > > > > When using <dubbo:service async="true" .../>, the Consumer will not be > > affected. However, the Consumer call will be affected when using > > <dubbo:method name="sayHello" async="true"/>. > > > > Why they are not consistent? > > > > -- > > Best Regards！ > > Huxing > > -- Best Regards！ Huxing
