also merged the corresponding change from PR2913 [1] contributed from @biyuhao.
-Ian. 1. https://github.com/apache/incubator-dubbo/pull/2913 On Mon, Dec 10, 2018 at 4:21 PM Ian Luo <[email protected]> wrote: > https://github.com/apache/incubator-dubbo/pull/2917 is merged. > > On Fri, Dec 7, 2018 at 4:56 PM Ian Luo <[email protected]> wrote: > >> Thank you. This problem is quite weird. It cannot reproduce on my laptop. >> >> -Ian. >> >> On Fri, Dec 7, 2018 at 4:44 PM Yuhao Bi <[email protected]> wrote: >> >>> Sure! I'm working on it~ >>> >>> Ian Luo <[email protected]> 于2018年12月7日周五 下午4:29写道： >>> >>> > Yuhao, >>> > >>> > Today I tried to re-enable this test, unfortunately Travis CI reported >>> the >>> > similar failure (see below). Would you mind to take a look at the pull >>> > request [1] I enabled the test, and the corresponding CI job [2]? >>> > >>> > Failed tests: >>> > > CompletableFutureTaskTest.testCustomExecutor:98 >>> > > Wanted but not invoked: >>> > > executor.execute(<any>); >>> > > -> at >>> > > >>> > >>> org.apache.dubbo.common.concurrent.CompletableFutureTaskTest.testCustomExecutor(CompletableFutureTaskTest.java:98) >>> > > Actually, there were zero interactions with this mock. >>> > >>> > >>> > Thanks, >>> > -Ian. >>> > >>> > 1. https://github.com/apache/incubator-dubbo/pull/2907 >>> > 2. >>> > >>> > >>> https://travis-ci.org/apache/incubator-dubbo/builds/464756834?utm_source=github_status&utm_medium=notification >>> > >>> > >>> > On Thu, Dec 6, 2018 at 8:07 PM Yuhao Bi <[email protected]> wrote: >>> > >>> > > Hi there, >>> > > >>> > > I'm willing to give it a try, but I cannot change the Assignees in >>> issue >>> > > page. Maybe I don't have the authority. >>> > > My github id is *biyuhao *,could you please assign it to me? >>> > > >>> > > Thanks, >>> > > Yuhao >>> > > >>> > > Ian Luo <[email protected]> 于2018年12月6日周四 下午7:39写道： >>> > > >>> > > > Hi folks, >>> > > > >>> > > > Today I noticed that Travis job started to fail, but I cannot >>> figure >>> > out >>> > > > the commit which should be blamed. I managed to trace down >>> > > > CompletableFutureTaskTest#testCustomExecutor is responsible for it. >>> > Right >>> > > > now I simply add @ignore on it to make CI pass again. >>> > > > >>> > > > If someone is interested in enhance testCustomExecutor(), pls. go >>> ahead >>> > > to >>> > > > assign yourself issue 2899 [1]. >>> > > > >>> > > > Thanks, >>> > > > -Ian. >>> > > > >>> > > > 1. https://github.com/apache/incubator-dubbo/issues/2899 >>> > > > >>> > > >>> > >>> >>
