Hi Is LongObjectHashMap io.netty.util.collection.LongObjectHashMap<V>?
I just take a look at the usage of dubbo existing code, the Map<Long, Object> almost are java.util.concurrent.ConcurrentHashMap,but the LongObjectHashMap is not Thread Safe . How do think about it ? > 在 2018年12月13日,上午10:37,yuhang xiu <[email protected]> 写道: > > Ok, > If u have questions, pls bring them here. > Looking forward to your contributions. > > stormyu <[email protected]> 于2018年12月13日周四 上午10:33写道: > >>> Hi, all >>> I think so, I will start investigating the performance gap between the >> two >and send a performance report. Then I will sort out the map we need to >> replace. >> At 2018-12-13 10:22:20, "yuhang xiu" <[email protected]> wrote: >>> Hi, all >>> Recently, @y1317427691 claimed this part of the work on github, he will >>> start in the near future. >>> According to my personal assumptions, we need to investigate the >>> performance of longobjectmap first, and then start to sort out the map we >>> need to replace. >>> What do you think? >>> >>> >>> Huxing Zhang <[email protected]> 于2018年12月7日周五 上午11:15写道: >>> >>>> On Tue, Dec 4, 2018 at 9:43 PM Huxing Zhang <[email protected]> wrote: >>>>> >>>>> Hi, >>>>> >>>>> On Tue, Dec 4, 2018 at 4:24 PM yuhang xiu <[email protected]> wrote: >>>>>> >>>>>> Hi, community >>>>>> At present, there are many Map<Long, Object> type maps in dubbo. >> When >>>> using >>>>>> this kind of map, jdk performs automatic package. >>>>>> >>>>>> We can use longObjectMap(or intObjectMap or sth else) to replace >> these >>>> maps >>>>>> and add some performance. >>>>> >>>>> Do you have some benchmark result for this? >>>>> >>>>>> >>>>>> Similarly, I have opened an issue[1] to track the progress. Of >> course, >>>> I >>>>>> will still find a new person to complete the work, we will comb and >>>> replace >>>>>> these maps together. I have found a person. We will start the >>>> organizing >>>>>> work and the program, and will be synchronized to the mailing list >> and >>>>>> issue. ( >>>>>> He still has some work at the moment, so the discussion may be >> delayed >>>> for >>>>>> a few days) >>>>> >>>>> Can he be on the mailing list to discuss this? >>>>> >>>>>> >>>>>> By the way, there are a few pr content that is simple, I think we >> can >>>> do a >>>>>> review and merge them. The issue list is here: >>>>>> https://github.com/apache/incubator-dubbo/pull/2831 >>>>>> https://github.com/apache/incubator-dubbo/pull/2809 >>>> >>>> I have finished the following two prs: >>>> >>>> https://github.com/apache/incubator-dubbo/pull/2802 >>>> https://github.com/apache/incubator-dubbo/pull/2788 >>>> >>>> >>>> >>>>>> >>>>>> Can someone take a look? >>>>> >>>>> I saw your comments on some of the pull request. >>>>> I can take some of them this week. >>>>> >>>>>> >>>>>> [1]https://github.com/apache/incubator-dubbo/issues/2882 >>>>> >>>>> >>>>> >>>>> -- >>>>> Best Regards! >>>>> Huxing >>>> >>>> >>>> >>>> -- >>>> Best Regards! >>>> Huxing >>>> >>
