@Ian and @Huxing thanks for your caring. On Wed, Dec 19, 2018 at 11:17 AM Ian Luo <[email protected]> wrote:
> merged, your pull request looks good to me. Feel free to push multiple > times for one particular pull request, 'Squash and merge' on GitHub will do > the trick. > > -Ian. > > On Wed, Dec 19, 2018 at 10:12 AM Huxing Zhang <[email protected]> wrote: > > > Hi, > > > > On Wed, Dec 19, 2018 at 2:25 AM Imteyaz Khan <[email protected]> > > wrote: > > > > > > Hi All, > > > Raised a PR <https://github.com/apache/incubator-dubbo/pull/3010>for > > > addition of UT for dubbo-rpc-api for issue id 3011 > > > <https://github.com/apache/incubator-dubbo/issues/3011>. Please > review > > it. > > > https://github.com/apache/incubator-dubbo/pull/3010 > > > > > > Desclaimer: I am not much aware about github and tryin to learn stuff > on > > > it. I found deficult to combined multiple commits into single commit in > > my > > > fork repo brances but kind of scare how to do it. Any help would be > > > appreciated. > > > > Don't worry, these commits will be squashed when getting merged. > > To answer your question, please check [1] for more details. > > > > [1] > > > https://github.com/apache/incubator-dubbo/blob/master/CONTRIBUTING.md#contribution-flow > > > > > > > > -- > > Best Regards！ > > Huxing > > >
