Hi,
I am looking at your pull request[1], travis CI says that it fails due
to log size limit has been exceeded.
I checked the log file, I see lots of exceptions thrown there. For example:
grep -c "NumberFormatException" CI.log
708
But I didn't see that in master Travis CI log.
Could you please check why there is so many NumberFormatException thrown there?
I am not sure what is going on there, but I did see something we can improve:
In org.apache.dubbo.common.utils.ClassHelper#convertPrimitive we
should check the input String to ensure it is not empty, or a
NumberFormatException will be thrown.
I can easily reproduce this issue with following test case:
@Test
public void testConvertPrimitive() {
Object result = ClassHelper.convertPrimitive(Integer.class, "");
}
[1] https://github.com/apache/incubator-dubbo/pull/3027
On Thu, Dec 27, 2018 at 3:24 AM Imteyaz Khan <khan.imte...@gmail.com> wrote:
>
> Hi all,
> Travis CI are failing currently due to log size. Is it the same issue
> 3052 <https://github.com/apache/incubator-dubbo/issues/3052>?
--
Best Regards！
Huxing
